Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] Use token's eauth key if load omits it. #66662

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Commits on Jun 24, 2024

  1. Use token's eauth key if load omits it.

    - `get_auth_list` uses the load to perform ACL lookup but if no `eauth`
      key is present, `__get_acl` immediately returns.
    - For token-based authentication, where administrators would also like
      to write a custom eauth ACL module, this update allows `__get_acl` to
      check for such a module, either via the `eauth_acl_module`
      configuration value or fallback to the `eauth` module's `acl`
      function, if defined.
    Ryan Frantz committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    714aca2 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2024

  1. Add tests

    - Includes two tests:
      - Validates that the fallback to checking the static `external_auth` option works as expected.
      - Validates the case where a server is configured to perform external ACL lookups via `eauth_acl_module`, `load["eauth"]` is undefined and `token["eauth"]` _is_ defined.
    - Verified via `nox -e 'test-3(coverage=False)' -- tests/pytests/unit/auth/test_auth.py`
    RyanFrantz committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    c80f435 View commit details
    Browse the repository at this point in the history