Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false positives #2186

Merged
merged 3 commits into from
Jun 24, 2024
Merged

Fix false positives #2186

merged 3 commits into from
Jun 24, 2024

Conversation

sdushantha
Copy link
Member

@sdushantha sdushantha commented Jun 24, 2024

  • fixed freeCodeCamp false positive
  • fixed LibraryThing false positive
  • removed Zhihu due to false positives, closes Zhihu false positive #2153

@ppfeister
Copy link
Member

As long as those fixes work, this can be merged

The failed tests can be ignored. Reading the log, the only failure is the pentestit probe that was swapped out in #2187. All other tests pass.

@sdushantha
Copy link
Member Author

@ppfeister There is a merge conflict that needs to be fixed. I'll do it in the next 24 hours

@ppfeister
Copy link
Member

I can just 3wm it locally if needed, just takes a few seconds @sdushantha

@sdushantha
Copy link
Member Author

@ppfeister If you've got time, feel free to do it

@ppfeister ppfeister merged commit 61ef8eb into master Jun 24, 2024
0 of 15 checks passed
@ppfeister ppfeister deleted the fix-false-positives branch June 24, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zhihu false positive
2 participants