Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix false positives #2186

Merged
merged 3 commits into from
Jun 24, 2024
Merged

Fix false positives #2186

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2746e29
fixed freeCodeCamp false positive
sdushantha Jun 24, 2024
54bebcf
fixed LibraryThing false positive
sdushantha Jun 24, 2024
a9a62c2
removed Zhihu due to false positives
sdushantha Jun 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions docs/removed-sites.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1867,4 +1867,17 @@ __2024-04-24 :__ BCF seems to have gone defunct. Uncertain.
"urlMain": "https://bitcoinforum.com",
"username_claimed": "bitcoinforum.com"
}
```

## Zhihu
As of 24.06.2024, Zhihu returns false positives as they obfuscate the code thats returned. Checking for patterns may allow us to find a way to detect the existans of a user, this will be need to be worked on later
```json

"Zhihu": {
"errorMsg": "用户不存在",
"errorType": "message",
"url": "https://www.zhihu.com/people/{}",
"urlMain": "https://www.zhihu.com/",
"username_claimed": "blue"
}
```
12 changes: 2 additions & 10 deletions sherlock/resources/data.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1276,7 +1276,7 @@
"username_claimed": "blue"
},
"LibraryThing": {
"errorMsg": "This user doesn't exist",
"errorMsg": "Catalog your books online",
"errorType": "message",
"url": "https://www.librarything.com/profile/{}",
"urlMain": "https://www.librarything.com/",
Expand Down Expand Up @@ -2369,13 +2369,6 @@
"urlMain": "https://www.youtube.com/",
"username_claimed": "youtube"
},
"Zhihu": {
"errorMsg": "404",
"errorType": "message",
"url": "https://www.zhihu.com/people/{}",
"urlMain": "https://www.zhihu.com/",
"username_claimed": "blue"
},
"akniga": {
"errorType": "status_code",
"url": "https://akniga.org/profile/{}",
Expand Down Expand Up @@ -2480,8 +2473,7 @@
"username_claimed": "red"
},
"freecodecamp": {
"errorMsg": "{}",
"errorType": "message",
"errorType": "status_code",
"url": "https://www.freecodecamp.org/{}",
"urlMain": "https://www.freecodecamp.org/",
"urlProbe": "https://api.freecodecamp.org/api/users/get-public-profile?username={}",
Expand Down
Loading