Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed tests due to broken sites #2187

Merged
merged 3 commits into from
Jun 24, 2024
Merged

Fixed tests due to broken sites #2187

merged 3 commits into from
Jun 24, 2024

Conversation

sdushantha
Copy link
Member

Pentestit was being used in the test to test sites using response URL. The checking on this site no longer works. It has therefore been removed and the Kofi is not being used instead in the tests

@sdushantha
Copy link
Member Author

@ppfeister Are you able to help me with this one? Seems like the testing with response_url fails. I've manually checked Kofi and the everything seems to be fine, so I'm uncertain as to why the test is failing

@ppfeister
Copy link
Member

Some of your tests for this PR passed, as you can see in the summary -- so it's not a total failure for that test

But it appears that ko-fi is behind Cloudflare, meaning that some requests are likely to be blocked (particularly if many requests are sent at once). This can be confirmed in the job's output...

 E       AssertionError: assert <QueryStatus.WAF: 'WAF'> is <QueryStatus.CLAIMED: 'Claimed'>

We're looking for a status of Claimed but we're returning a WAF hit, and Cloudflare's WAF is one of the two detection that I've added for this status, so it all adds up in the end.

I'll see if there's a more consistent target we can use...

Copy link
Member

@ppfeister ppfeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be GTG

@sdushantha sdushantha merged commit 58df6bb into master Jun 24, 2024
15 checks passed
@ppfeister ppfeister mentioned this pull request Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants