Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds tolerations, nodeSelector, and affinity to tuf. #759

Conversation

ianhundere
Copy link
Contributor

@ianhundere ianhundere commented May 23, 2024

Partly resolves #696

Description of the change

Adds tolerations, nodeSelector and affinity to charts.

Existing or Associated Issue(s)

Request for tolerations, nodeSelector and affinity to be allowed to configure for all charts

Additional Information

initial PR w/ all changes in one.

Checklist

  • Chart version bumped in Chart.yaml according to semver. Where applicable, update and bump the versions in any associated umbrella chart
  • Variables are documented in the values.yaml and added to the README.md. The helm-docs utility can be used to generate the necessary content. Use helm-docs --dry-run to preview the content.
  • JSON Schema generated.
  • List tests pass for Chart using the Chart Testing tool and the ct lint command.
❯ ct lint --config ct.yaml
Linting charts...

------------------------------------------------------------------------------------------------------------------------
 Charts to be processed:
------------------------------------------------------------------------------------------------------------------------
 tuf => (version: "0.1.13", path: "charts/tuf")
------------------------------------------------------------------------------------------------------------------------

"sigstore" already exists with the same configuration, skipping
Linting chart "tuf => (version: \"0.1.13\", path: \"charts/tuf\")"
Checking chart "tuf => (version: \"0.1.13\", path: \"charts/tuf\")" for a version bump...
Old chart version: 0.1.12
New chart version: 0.1.13
Chart version ok.
Validating /Users/x308080/Projects/helmcharts-2/charts/tuf/Chart.yaml...
Validation success! 👍

Linting chart with values file "charts/tuf/ci/ci-values.yaml"...

==> Linting charts/tuf
[INFO] Chart.yaml: icon is recommended

1 chart(s) linted, 0 chart(s) failed

------------------------------------------------------------------------------------------------------------------------
 ✔︎ tuf => (version: "0.1.13", path: "charts/tuf")
------------------------------------------------------------------------------------------------------------------------
All charts linted successfully

cc @hectorj2f / @cpanato

@ianhundere ianhundere force-pushed the adds_tolerations_nodeSelector_and_affinity_to_tuf branch 3 times, most recently from 93411cc to c8b39c1 Compare May 23, 2024 20:34
@ianhundere ianhundere force-pushed the adds_tolerations_nodeSelector_and_affinity_to_tuf branch 3 times, most recently from 0dea3a7 to 2e31d4b Compare June 13, 2024 22:40
@ianhundere ianhundere force-pushed the adds_tolerations_nodeSelector_and_affinity_to_tuf branch from 2e31d4b to 4972897 Compare June 25, 2024 18:14
@cpanato
Copy link
Member

cpanato commented Jun 26, 2024

@ianhundere can you rebase please? just to get the updated code?

@ianhundere ianhundere force-pushed the adds_tolerations_nodeSelector_and_affinity_to_tuf branch from 4972897 to 5e780f8 Compare June 26, 2024 10:00
@ianhundere
Copy link
Contributor Author

@ianhundere can you rebase please? just to get the updated code?

will do, and i'll rebase scaffold (and update chart semvers again) once this and rekor are merged.

@cpanato cpanato merged commit da3be81 into sigstore:main Jun 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request for tolerations, nodeSelector and affinity to be allowed to configure for all charts
2 participants