Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insert null attribute as is in feature table #2377

Merged
merged 4 commits into from
Jun 5, 2024

Conversation

AlvaroVega
Copy link
Member

@AlvaroVega AlvaroVega commented Jun 4, 2024

to allow null attribute value

#2376

@AlvaroVega AlvaroVega changed the title [WIP] allow null attribute value for url [WIP] Insert null attribute as is in feature table Jun 5, 2024
@AlvaroVega AlvaroVega marked this pull request as ready for review June 5, 2024 08:07
@AlvaroVega AlvaroVega changed the title [WIP] Insert null attribute as is in feature table Insert null attribute as is in feature table Jun 5, 2024
LOGGER.warn(
"[NGSIArcgisAggregator] Unquoted String attribute: " + attrName + ":" + attrValue);
String strValue = URLDecoder.decode(attrValue.toString());
feature.addAttribute(attrName, strValue);
// If all fails, insert as String
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand this comment is no longer valid, as not always is inserted as String (in the case of null is inserted as it is)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in e4af776

Copy link
Member

@fgalan fgalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fgalan fgalan merged commit 7de533e into master Jun 5, 2024
7 checks passed
@fgalan fgalan deleted the task/null_attribute_value_url branch June 5, 2024 08:23
@AlvaroVega AlvaroVega mentioned this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants