Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check if featureTable is connected before use it (arcgis) #2421

Merged
merged 6 commits into from
Oct 1, 2024
Merged

check if featureTable is connected before use it (arcgis) #2421

merged 6 commits into from
Oct 1, 2024

Conversation

AlvaroVega
Copy link
Member

@AlvaroVega AlvaroVega commented Sep 27, 2024 •
edited
Loading

Otherwiese new one is created

Fix for #2405

@AlvaroVega AlvaroVega changed the title Task/log reuse persistence backend arcgis [WIP] Task/log reuse persistence backend arcgis Sep 27, 2024
@AlvaroVega
Copy link
Member Author

AlvaroVega commented Sep 27, 2024 •
edited
Loading

Maybe when connection error (i.e. credentials are changed) there is no way to reconnect since a connection error is not tainting feature table as not connected:
#2405

@AlvaroVega AlvaroVega changed the title [WIP] Task/log reuse persistence backend arcgis [WIP] check if featureTable is connected before use it Sep 27, 2024
@AlvaroVega
Copy link
Member Author

Docker image for this branch/PR https://hub.docker.com/layers/telefonicaiot/fiware-cygnus/arcgisreconnect/images/sha256-de5c0749e71f593ebc77bf12e34007a6792191e5aa6bac6d5f2b2c61290fcd16?context=repo

@AlvaroVega AlvaroVega changed the title [WIP] check if featureTable is connected before use it [WIP] check if featureTable is connected before use it (arcgis) Sep 27, 2024
@AlvaroVega AlvaroVega marked this pull request as ready for review October 1, 2024 14:04
@AlvaroVega AlvaroVega requested a review from fgalan October 1, 2024 14:04
@AlvaroVega AlvaroVega changed the title [WIP] check if featureTable is connected before use it (arcgis) check if featureTable is connected before use it (arcgis) Oct 1, 2024
fgalan
fgalan reviewed Oct 1, 2024
View reviewed changes
CHANGES_NEXT_RELEASE Outdated
Comment on lines 1 to 2
- [cygnus-ngsi][arcgis] Check feature table is connected before use it
- [cygnus-ngsi][arcgis] Set feature table to not connected after a connection error
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#2405 should be mentioned here?

fgalan
fgalan approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member

@fgalan fgalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fgalan fgalan merged commit d03e685 into master Oct 1, 2024
8 checks passed
@fgalan fgalan deleted the task/log_reuse_persistenceBackend_arcgis branch October 1, 2024 14:47
@fgalan fgalan mentioned this pull request Oct 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fgalan fgalan fgalan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlvaroVega @fgalan