REMOVE Ubuntu 20.04 LTS section #4423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgalan
reviewed
Sep 11, 2023
| @@ -1,6 +1,6 @@ | |||
| # Building from sources | |||
|
|
|||
| Orion Context Broker reference distribution is Debian 12. This doesn't mean that the broker cannot be built in other distributions (actually, it can). This section also includes indications on how to build in other distributions, just in the case it may help people that don't use Debian. However, note that the only "officially supported" procedure is the one for Debian 12; the others are provided "as is" and can get obsolete from time to time. | |||
There was a problem hiding this comment.
Although after the removal of the Ubuntu section the only procedure would be the one about Debian 12, I'd suggest to keep this fragment just in case in the future another non official procedures would be included, with the following change:
This section also includes indications...
to
This section may include indications...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes "Ubuntu 20.04 LTS" section from admin/build_source.md.
When I added Ubuntu 18.04 and Ubuntu 20.04 sections, Orion Context Broker reference distribution was CentOS 7. There are differences between these distributions, so the procedure building Orion for Ubuntu was necessary. After that, the reference distribution was changed to Deiban. The current one is Debian 12.
Currently, the latest version of Ubuntu LTS (Long Term Support) is 22.04. So, I think that Ubuntu 20.04 LTS section should be update to Ubuntu 22.04 LTS section. But, the base distribution of Ubuntu 22.04 LTS is Debian 12. As I show the PR #4422, Orion on Ubuntu 22.04 can be built by the same procedure as Debian 12. Therefore, I thnink that the section to build Orion on Ubuntu is unnecessary.
It would be great if you could review the PR.
Thanks.