Skip explicitAttrs No Lib #1531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgalan
reviewed
Nov 23, 2023
| @@ -2424,6 +2424,7 @@ const testCases = [ | |||
| { | |||
| shouldName: 'C - WHEN sending only b IT should store only [{object_id:b}] attrs into Context Broker', | |||
| type: 'single', | |||
| skip: '!lib', // FIXME: https://github.com/telefonicaid/iotagent-json/issues/782 | |||
There was a problem hiding this comment.
The usage of lib is documented in https://github.com/telefonicaid/iotagent-node-lib/blob/master/test/functional/README.md, but not the usage of !lib. Maybe that document should be improved to explain the !lib case.
There was a problem hiding this comment.
You are right. Anyway, I think the best is to create a separated PR.
There was a problem hiding this comment.
Let's do it and merge both at the same time?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify tests to skip this cases in JSON agent untill the following issue is fixed:
telefonicaid/iotagent-json#782