Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip explicitAttrs No Lib #1531

Merged
merged 2 commits into from
Nov 24, 2023
Merged

Skip explicitAttrs No Lib #1531

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9638ab6
Skip explicitAttrs No Lib
mapedraza Nov 22, 2023
bb2915c
add comma
mapedraza Nov 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions test/functional/testCases.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2424,6 +2424,7 @@ const testCases = [
{
shouldName: 'C - WHEN sending only b IT should store only [{object_id:b}] attrs into Context Broker',
type: 'single',
skip: '!lib', // FIXME: https://github.com/telefonicaid/iotagent-json/issues/782
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The usage of lib is documented in https://github.com/telefonicaid/iotagent-node-lib/blob/master/test/functional/README.md, but not the usage of !lib. Maybe that document should be improved to explain the !lib case.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. Anyway, I think the best is to create a separated PR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do it and merge both at the same time?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1532

measure: {
url: 'http://localhost:' + config.http.port + '/iot/json',
method: 'POST',
Expand All @@ -2450,6 +2451,7 @@ const testCases = [
shouldName:
'D - WHEN no sending any defined case IT should store [static_a,static_b] attrs into Context Broker',
type: 'single',
skip: '!lib', // FIXME: https://github.com/telefonicaid/iotagent-json/issues/782
measure: {
url: 'http://localhost:' + config.http.port + '/iot/json',
method: 'POST',
Expand Down
Loading