Fix: session vs token issue #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pieterlukasse
commented
Jul 31, 2024
Comment on lines
+118
to
+122
| // stop session to make logout of OAuth users possible | ||
| Session session = SecurityUtils.getSubject().getSession(false); | ||
| if (session != null) { | ||
| session.stop(); | ||
| } |
There was a problem hiding this comment.
m0nhawk
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to JIRA ticket if there is one: https://ctds-planx.atlassian.net/browse/VADC-1241
Bug Fixes
session.stop()code from upstream. In practice this results in a behavior where the token expiry can be used to expire both the token and (indirectly - through a side-effect in upstream code) the session, and sosecurity.token.expirationcould be used to control session length (Feat: set webapi token exp. to 15 min and refresh when 4 min left cloud-automation#2589)