fix: work with recent apsw #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalc
force-pushed
the
fix/recent-apsw
branch
5 times, most recently
from
738a386
to
525b9ba
Compare
It looks like from apsw 3.43.1.1 onwards, the virtual filesystem file needs the xSectorSize function. Nothing in the apsw changelog at https://rogerbinns.github.io/apsw/changes.html makes this particular clear - the issue from 3.43.1.1 onwards was determined by running the tests for sqlite-s3vfs for each apsw version. The sector size of "0" for some reason is the only one that makes the rollback tests pass Thank you to https://github.com/blueshed for the report Closes #24
michalc
force-pushed
the
fix/recent-apsw
branch
from
525b9ba
to
f94a862
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like from apsw 3.43.1.1 onwards, the virtual filesystem file needs the xSectorSize function.
Nothing in the apsw changelog at https://rogerbinns.github.io/apsw/changes.html makes this particular clear - the issue from 3.43.1.1 onwards was determined by running the tests for sqlite-s3vfs for each apsw version.
The sector size of "0" for some reason is the only one that makes the rollback tests pass
Thank you to @blueshed for the report.
Closes #24