Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typing_extensions to pyproject.toml dependencies #413

Closed
wants to merge 1 commit into from
Closed

Add typing_extensions to pyproject.toml dependencies #413

wants to merge 1 commit into from

Conversation

Jasha10
Copy link

@Jasha10 Jasha10 commented May 14, 2023

Closes #412.

@CLAassistant
Copy link

CLAassistant commented May 14, 2023

CLA assistant check
All committers have signed the CLA.

@tony
Copy link
Member

tony commented May 14, 2023

Thank you for the PR (And for the issue at #412 as well), @Jasha10!

As for if we go this way: Maybe. There is one more thing I want to try

I am going to try an approach that uses type guards to (attempt) to stave off the extra dependency. If that doesn't pan out, I will merge the approach

@codecov
Copy link

codecov bot commented May 14, 2023

Codecov Report

Merging #413 (e25b00f) into master (18a73e4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #413   +/-   ##
=======================================
  Coverage   84.00%   84.00%           
=======================================
  Files          17       17           
  Lines         938      938           
  Branches      168      168           
=======================================
  Hits          788      788           
  Misses        100      100           
  Partials       50       50           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

tony added a commit that referenced this pull request May 14, 2023
@Jasha10
Copy link
Author

Jasha10 commented May 15, 2023

Closing -- this PR is obviated now that #414 is merged.

@Jasha10 Jasha10 closed this May 15, 2023
@Jasha10 Jasha10 deleted the fix-deps branch May 15, 2023 07:54
@tony
Copy link
Member

tony commented May 15, 2023

Should maintaining the pattern in #414 be too much to maintain dependably we can re-open this in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pipx - ModuleNotFoundError: No module named 'typing_extensions'
3 participants