Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(types): Hide .types imports behind TypeGuard #414

Merged
merged 2 commits into from
May 14, 2023
Merged

Conversation

tony
Copy link
Member

@tony tony commented May 14, 2023

This avoids the need for typing-extensions as an official dependency and fixes #412.

IF this way doesn't work, merge @Jasha10's approach at #413

This avoids the need for typing-extensions as an official dependency and
fixes #412.
@codecov
Copy link

codecov bot commented May 14, 2023

Codecov Report

Merging #414 (435a26c) into master (18a73e4) will decrease coverage by 0.46%.
The diff coverage is 100.00%.

❗ Current head 435a26c differs from pull request most recent head 325af1c. Consider uploading reports for the commit 325af1c to get more accurate results

@@            Coverage Diff             @@
##           master     #414      +/-   ##
==========================================
- Coverage   84.00%   83.55%   -0.46%     
==========================================
  Files          17       16       -1     
  Lines         938      912      -26     
  Branches      168      168              
==========================================
- Hits          788      762      -26     
  Misses        100      100              
  Partials       50       50              
Impacted Files Coverage Δ
src/vcspull/validator.py 36.84% <ø> (-3.16%) ⬇️
tests/test_config.py 96.87% <ø> (-0.10%) ⬇️
src/vcspull/config.py 84.55% <100.00%> (-0.12%) ⬇️
tests/fixtures/example.py 100.00% <100.00%> (ø)
tests/test_sync.py 90.14% <100.00%> (-0.14%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tony tony merged commit 2ff9ae5 into master May 14, 2023
6 checks passed
@tony tony deleted the types-imports branch May 14, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pipx - ModuleNotFoundError: No module named 'typing_extensions'
1 participant