Run specs with redis client #65
Conversation
laurafeier
force-pushed
the
feature/specs-for-redis-client
branch
3 times, most recently
from
fdef8ab
to
ef1f1ff
Compare
activejob-uniqueness.gemspec
Outdated
| spec.add_development_dependency 'appraisal', '~> 2.3.0' | ||
| spec.add_development_dependency 'bundler', '>= 2.0' | ||
| spec.add_development_dependency 'pry-byebug', '> 3.6.0' | ||
| spec.add_development_dependency 'rspec', '~> 3.0' | ||
| spec.add_development_dependency 'rubocop', '~> 1.28' | ||
| spec.add_development_dependency 'rubocop-rspec', '~> 2.10' |
There was a problem hiding this comment.
Hey @laurafeier
Thank you for the PR!
Could you explain why this change is necessary?
There was a problem hiding this comment.
Ah, I see Gemspec/DevelopmentDependencies: Specify development dependencies in Gemfile
https://docs.rubocop.org/rubocop/cops_gemspec.html#gemspecdevelopmentdependencies
TBH I do not see any value in this change. I'd prefer to disable the cop instead
There was a problem hiding this comment.
This cop is not available for older versions of rubocop which are installed with older ruby version. If you disable it, the rule is not recognized by older rubocop and it fails. I think this is the only way to have it working with older & newer ruby versions.
Error output for following:
ruby 2.5
rubocop 1.28.2
Error: unrecognized cop or department Gemspec/DevelopmentDependencies found in .rubocop.yml
Did you mean `Gemspec/OrderedDependencies`?
Even if you disable the rule in robocop.yml, it will still give the same error. I will update the PR by excluding the .gemspec file entirely.
laurafeier
force-pushed
the
feature/specs-for-redis-client
branch
2 times, most recently
from
5f18eb2
to
5140210
Compare
laurafeier
force-pushed
the
feature/specs-for-redis-client
branch
from
5140210
to
e7db43b
Compare
No description provided.