refactor(stop_filter): prefix package and namespace with autoware #7789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esteve
added
the
tag:run-build-and-test-differential
github-actions
bot
added
type:documentation
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7789 +/- ##
==========================================
- Coverage 28.55% 28.55% -0.01%
==========================================
Files 1586 1587 +1
Lines 115879 115899 +20
Branches 49362 49362
==========================================
Hits 33094 33094
- Misses 73745 73765 +20
Partials 9040 9040
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
esteve
force-pushed
the
prefix-stop_filter
branch
from
b328353
to
4b266d4
Compare
esteve
changed the title
esteve
requested review from
anhnv3991,
KYabuuchi,
kminoda,
Motsu-san,
RyuYamamoto,
SakodaShintaro,
TaikiYamada4 and
YamatoAndo
as code owners
SakodaShintaro
requested changes
Jul 3, 2024
There was a problem hiding this comment.
Thank you!
I think the two launch files need to be changed as well.
$(find-pkg-share stop_filter) -> $(find-pkg-share autoware_stop_filter)
- in
localization/autoware_stop_filter/launch/stop_filter.launch.xml
- in
launch/tier4_localization_launch/launch/pose_twist_fusion_filter/pose_twist_fusion_filter.launch.xml
|
@SakodaShintaro fixed in 662e0f7 |
github-actions
bot
added
type:ci
SakodaShintaro
approved these changes
Jul 3, 2024
|
There are errors with cppcheck, but it seems that they will be fixed by merging the latest main branch. |
Signed-off-by: Esteve Fernandez <[email protected]>
Signed-off-by: Esteve Fernandez <[email protected]>
esteve
force-pushed
the
prefix-stop_filter
branch
from
662e0f7
to
5859c78
Compare
SakodaShintaro
added a commit
to SakodaShintaro/autoware.universe
that referenced
this pull request
Jul 4, 2024
…ware (autowarefoundation#7789)" This reverts commit fbbc44c.
This was referenced Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
prefix package and namespace with autoware
Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.