Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Umbrella Issue] Migrate prow jobs to community clusters #29722

Open
53 of 54 tasks
rjsadow opened this issue Jun 7, 2023 · 28 comments
Open
53 of 54 tasks

[Umbrella Issue] Migrate prow jobs to community clusters #29722

rjsadow opened this issue Jun 7, 2023 · 28 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra.

Comments

@rjsadow
Copy link
Contributor

rjsadow commented Jun 7, 2023 •
edited
Loading

In an ongoing effort to migrate to community-owned resources, SIG K8S Infra and SIG Testing are working to complete the migration of jobs from the Google-owned internal GKE cluster to community-owned clusters.

All jobs in the Prow Default Cluster that do not depend on external cloud assets should attempt migrate to cluster: eks-prow-build-cluster.

What needs to be done?

To get started please see eks-jobs-migration for details.

Fork and check out the kubernetes/test-infra repository, then follow the steps below:

  1. Find the name of the job you wish to check has a cluster specified or not say pull-jobset-test-integration-main from the "Prow Results" link below.
  2. Edit the file that pull-jobset-test-integration-main is defined in from the "Search Results" link, in the job definition look for a cluster: key, if there isn't one then the job runs in the default cluster, So add one cluster: eks-prow-build-cluster. NOTE: if you see any entries under label that says gce skip this job and go to the next time as this is not ready to be moved yet.
  3. Save the file, commit the change, create a branch and file a PR
  4. Having trouble? Leave a note here in this issue and/or come to #sig-k8s-infra or #sig-testing slack channel to ask for help

NOTE: The Google-owned clusters did not require any resource definitions whereas the community-owned clusters do. If your merge is failing the pull-test-infra-unit-test job, please add CPU/Memory requests/limits. Work with the appropriate sig owners to determine the necessary capacity for each job.

Below is a list of repos that currently have jobs in the default cluster.

Repos with default cluster jobs found
@rjsadow rjsadow added the kind/bug Categorizes issue or PR as related to a bug. label Jun 7, 2023
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jun 7, 2023
@rjsadow
Copy link
Contributor Author

rjsadow commented Jun 7, 2023

/sig k8s-infra
/kind cleanup

@k8s-ci-robot k8s-ci-robot added sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 7, 2023
@rjsadow rjsadow mentioned this issue Jun 8, 2023
Merged
@ameukam
Copy link
Member

ameukam commented Jun 8, 2023 •
edited
Loading

For kops, we have a separate issue: kubernetes/k8s.io#5127
I think for the moment it's better to focus on the presubmits.

@rayandas
Copy link
Member

rayandas commented Jun 8, 2023

@dims Can I pick up the cluster-api jobs? I will migrate as much as I can.

@ameukam
Copy link
Member

ameukam commented Jun 8, 2023 •
edited
Loading

@dims Can I pick up the cluster-api jobs? I will migrate as much as I can.

@rayandas @rjsadow There is an ongoing effort about cluster-api. Please coordinate with cluster-api maintainers

@ArkaSaha30 ArkaSaha30 mentioned this issue Jun 8, 2023
Merged
@ArkaSaha30
Copy link
Member

Hello @dims, I am familiar with kubernetes/sig-release jobs so is it okay to work on it?
cc @ameukam

@rjsadow
Copy link
Contributor Author

rjsadow commented Jun 8, 2023

@dims @ameukam I think the pull-test-infra-unit-test job requiring resoure limits/requests for the community clusters is going to be a stumbling block for a lot of these migrations. Is there any existing documentation or resources that we can empower contributers to reference to for setting initial values then iterating? Or should we expect the sig maintainters and leads to help provide input on a job-by-job basis?

Example in #29724 where I WAG'd .5CPU and 2GB and asked the cluster lifecycle leads to review.

@kranurag7 kranurag7 mentioned this issue Jun 8, 2023
Merged
@ShivamTyagi12345
Copy link
Member

I would like to learn more about this , so I will pick one kubernetes-sigs/kustomize | Search Results |

@ShivamTyagi12345 ShivamTyagi12345 mentioned this issue Jun 8, 2023
Merged
@michelle192837 michelle192837 mentioned this issue Jun 8, 2023
Merged
@furkatgofurov7 furkatgofurov7 mentioned this issue Jun 9, 2023
Closed
@furkatgofurov7
Copy link
Member

What needs to be done?

Fork and check out the kubernetes/test-infra repository, then follow the steps below:

  1. Find the name of the job you wish to check has a cluster specified or not say pull-jobset-test-integration-main from the "Search Results" link above

  2. Find the yaml file in kubernetes/test-infra using our search:

  3. Edit the file in step 2, in the job definition look for a cluster: key, if there isn't one then the job runs in the default cluster, So add one cluster: eks-prow-build-cluster. NOTE: if you see any entries under label that says gce skip this job and go to the next time as this is not ready to be moved yet.

  4. Save the file, commit the change, create a branch and file a PR

  5. Having trouble? Leave a note here in this issue and/or come to #sig-k8s-infra or #sig-testing slack channel to ask for help

@dims hi, thanks for sharing the steps. Also I noticed PR's moving to new clusters with just specifying the new cluster name, there are others specifying resource quotas (CPU/memory) while migrating. Is the latter requirement or generally maybe recommended while just specifying the name is also enough?

@lentzi90 lentzi90 mentioned this issue Jun 9, 2023
Merged
This was referenced Jun 9, 2023
Merged
Merged
@rjsadow
Copy link
Contributor Author

rjsadow commented Jun 9, 2023

Is the latter requirement or generally maybe recommended while just specifying the name is also enough?

The Google-owned clusters did not require any resource definitions whereas the community-owned clusters do. If a job already has resource quotas (both requests and limits) then just the name is enough. If the job is missing any resource quotas then those will need to be added or else the pull-test-infra-unit-test check will fail.

@furkatgofurov7 furkatgofurov7 mentioned this issue Jun 9, 2023
Merged
@rjsadow rjsadow mentioned this issue Jun 9, 2023
Closed
This was referenced Jun 9, 2023
Closed
Merged
Merged
@Vyom-Yadav
Copy link
Member

I will be working on kubernetes/node-problem-detector | Prow Results | Search Results

@Vyom-Yadav Vyom-Yadav mentioned this issue Jun 10, 2023
Merged
This was referenced Sep 10, 2023
Merged
Closed
Merged
This was referenced Sep 15, 2023
Merged
Merged
@liangyuanpeng liangyuanpeng mentioned this issue Sep 19, 2023
Closed
@upodroid upodroid mentioned this issue Sep 21, 2023
Merged
@kannon92 kannon92 mentioned this issue Sep 21, 2023
Merged
This was referenced Oct 1, 2023
Merged
Merged
@tallclair tallclair mentioned this issue Oct 13, 2023
Closed
@wzshiming wzshiming mentioned this issue Oct 31, 2023
Closed
This was referenced Nov 13, 2023
Merged
Merged
@upodroid upodroid mentioned this issue Nov 23, 2023
Merged
ameukam added a commit to ameukam/test-infra that referenced this issue Jan 12, 2024
@ameukam
kind: more a few tests.
1daf56e 
Part of:
  -  kubernetes#29722

Move a few jobs still running on Google Infra.

Signed-off-by: Arnaud Meukam <[email protected]>
@ameukam ameukam mentioned this issue Jan 12, 2024
Merged
ameukam added a commit to ameukam/test-infra that referenced this issue Jan 12, 2024
@ameukam
kind: more a few tests.
ba599aa 
Part of:
  -  kubernetes#29722

Move a few jobs still running on Google Infra.

Signed-off-by: Arnaud Meukam <[email protected]>
@rjsadow rjsadow mentioned this issue Feb 1, 2024
Open
16 tasks
@soravkumarsharma soravkumarsharma mentioned this issue Feb 7, 2024
Closed
@lentzi90 lentzi90 mentioned this issue Feb 27, 2024
Closed
21 tasks
@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 21, 2024
@BenTheElder
Copy link
Member

/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 25, 2024
@kubernetes kubernetes deleted a comment from k8s-triage-robot Mar 25, 2024
@BenTheElder
Copy link
Member

xref: #32432

@BenTheElder BenTheElder mentioned this issue Jun 24, 2024
Closed
@BenTheElder
Copy link
Member

We're also keeping this list up to date: https://github.com/kubernetes/test-infra/blob/master/docs/job-migration-todo.md

@BenTheElder
Copy link
Member

BenTheElder commented Jun 26, 2024 •
edited
Loading

filed a few warnings:
kubernetes/kops#16637
kubernetes-sigs/node-feature-discovery#1747
kubernetes/node-problem-detector#920

+ messages in slack, in addition to the kubernetes-dev emails

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Migrate prow jobs to community clusters soravkumarsharma/test-infra